Chronological Thread 

< Chronological >      < Thread >

---

CellML Automated Notifications wrote:
> Revision: 3345
> Author: agarny
> Date: 2009-04-01 19:27:40 +1300 (Wed, 01 Apr 2009)
>
> Log Message:
> -----------
> Removed the console error messages by removing the "-moz-stack-sizing"
> property and by adding branding properties.
> This is not related to any particular tracker item. Just that I like things
> to be 'clean'...
>
Hi,

I think we should have a tracker item for this, because it is difficult
to comment on these otherwise.

I don't think we should be doing this in the absence of any alternative
to -moz-stack-sizing - especially since our patch to support
-moz-stack-sizing is in mozilla-central, and so it is only people using
older versions of Mozilla which don't have this patch who will see the
warning. It therefore seems like this change will introduce a regression
for properly patched Mozilla versions.

Best wishes,
Andrew

> Modified Paths:
> --------------
> pce/trunk/chrome/content/controls/modeltreeview.xml
> pce/trunk/chrome.manifest
>
> Added Paths:
> -----------
> pce/trunk/chrome/locale/en-US/
> pce/trunk/chrome/locale/en-US/branding/
> pce/trunk/chrome/locale/en-US/branding/brand.properties
>
> Modified: pce/trunk/chrome/content/controls/modeltreeview.xml
> ===================================================================
> --- pce/trunk/chrome/content/controls/modeltreeview.xml 2009-04-01
> 06:18:28 UTC (rev 3344)
> +++ pce/trunk/chrome/content/controls/modeltreeview.xml 2009-04-01
> 06:27:40 UTC (rev 3345)
> @@ -324,17 +324,17 @@
> <xul:xmleditor anonid="xmleditor" flex="1"/>
> </xul:deck>
> <xul:box style="display: none">
> - <xul:treeviewtextbox anonid="editbox1" style="font-size: 10pt;
> display: none; -moz-stack-sizing: ignore" />
> - <xul:treeviewtextbox anonid="editbox2" style="font-size: 10pt;
> display: none; -moz-stack-sizing: ignore" />
> - <xul:box anonid="rendered_units" style="display: none;
> -moz-stack-sizing: ignore" >
> + <xul:treeviewtextbox anonid="editbox1" style="font-size: 10pt;
> display: none" />
> + <xul:treeviewtextbox anonid="editbox2" style="font-size: 10pt;
> display: none" />
> + <xul:box anonid="rendered_units" style="display: none" >
> <html:div anonid="rendered_units_div"/>
> </xul:box>
> <xul:menulist anonid="dropdown1"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore" modeltreeview="true" editable="true">
> + style="font-size: 10pt; display: none"
> modeltreeview="true" editable="true">
> <xul:menupopup anonid="dropdown1popup" />
> </xul:menulist>
> <xul:menulist anonid="interface_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore" modeltreeview="true">
> + style="font-size: 10pt; display: none"
> modeltreeview="true">
> <xul:menupopup>
> <xul:menuitem label="In" value="In" />
> <xul:menuitem label="Out" value="Out" />
> @@ -342,7 +342,7 @@
> </xul:menupopup>
> </xul:menulist>
> <xul:menulist anonid="role_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore"
> + style="font-size: 10pt; display: none"
> modeltreeview="true">
> <xul:menupopup>
> <xul:menuitem label="Reactant" value="Reactant" />
> @@ -355,7 +355,7 @@
> </xul:menupopup>
> </xul:menulist>
> <xul:menulist anonid="derived_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore"
> + style="font-size: 10pt; display: none"
> modeltreeview="true">
> <xul:menupopup>
> <xul:menuitem label="Derived" value="Derived" />
> @@ -363,7 +363,7 @@
> </xul:menupopup>
> </xul:menulist>
> <xul:menulist anonid="relationshipref_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore"
> + style="font-size: 10pt; display: none"
> modeltreeview="true" editable="true">
> <xul:menupopup>
> <xul:menuitem label="encapsulation" value="encapsulation" />
> @@ -371,7 +371,7 @@
> </xul:menupopup>
> </xul:menulist>
> <xul:menulist anonid="reversibility_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore"
> + style="font-size: 10pt; display: none"
> modeltreeview="true">
> <xul:menupopup>
> <xul:menuitem label="Reversible" value="Reversible" />
> @@ -379,7 +379,7 @@
> </xul:menupopup>
> </xul:menulist>
> <xul:menulist anonid="direction_dropdown"
> - style="font-size: 10pt; display: none;
> -moz-stack-sizing: ignore"
> + style="font-size: 10pt; display: none"
> modeltreeview="true">
> <xul:menupopup>
> <xul:menuitem label="Forward" value="Forward" />
>
> Added: pce/trunk/chrome/locale/en-US/branding/brand.properties
> ===================================================================
> --- pce/trunk/chrome/locale/en-US/branding/brand.properties
> (rev 0)
> +++ pce/trunk/chrome/locale/en-US/branding/brand.properties 2009-04-01
> 06:27:40 UTC (rev 3345)
> @@ -0,0 +1,2 @@
> +brandShortName=OpenCell
> +brandFullName=OpenCell
>
> Modified: pce/trunk/chrome.manifest
> ===================================================================
> --- pce/trunk/chrome.manifest 2009-04-01 06:18:28 UTC (rev 3344)
> +++ pce/trunk/chrome.manifest 2009-04-01 06:27:40 UTC (rev 3345)
> @@ -1,2 +1,3 @@
> content opencell jar:opencell.jar!/content/
> skin opencell classic/1.0 jar:opencell.jar!/skin/
> +locale branding en-US jar:opencell.jar!/locale/en-US/branding/
> \ No newline at end of file
>
>
> _______________________________________________
> automated-notifications mailing list
> automated-notifications at cellml.org
> http://www.cellml.org/mailman/listinfo/automated-notifications
>

---

• [cellml-dev] [3345] pce/trunk: Removed the console error messages by removing the " -moz-stack-sizing" property and by adding branding properties., Andrew Miller, 04/02/2009
  • [cellml-dev] [3345] pce/trunk: Removed the console error messages by removing the " -moz-stack-sizing" property and by adding branding properties., Alan Garny, 04/02/2009

---

Archive powered by MHonArc 2.6.18.