A list for the developers of CellML tools

Text archives Help


[cellml-dev] [3345] pce/trunk: Removed the console error messages by removing the " -moz-stack-sizing" property and by adding branding properties.


Chronological Thread 
  • From: alan.garny at dpag.ox.ac.uk (Alan Garny)
  • Subject: [cellml-dev] [3345] pce/trunk: Removed the console error messages by removing the " -moz-stack-sizing" property and by adding branding properties.
  • Date: Thu, 2 Apr 2009 15:31:26 +1300

> CellML Automated Notifications wrote:
> > Revision: 3345
> > Author: agarny
> > Date: 2009-04-01 19:27:40 +1300 (Wed, 01 Apr 2009)
> >
> > Log Message:
> > -----------
> > Removed the console error messages by removing the "-moz-stack-sizing"
> property and by adding branding properties.
> > This is not related to any particular tracker item. Just that I like
> things to be 'clean'...
> >
> Hi,
>
> I think we should have a tracker item for this, because it is difficult
> to comment on these otherwise.

Isn't what you are doing here? Granted, it's not as easy to search and refer
to.

This being said, do we honestly need to create a tracker item for every
single tiny commit like this? If so, then I am going to end up creating tons
of them, as there are loads of tiny things like this that really bug me in
OpenCell. Sure, they are not critical, but that looks 'bad'.

> I don't think we should be doing this in the absence of any alternative
> to -moz-stack-sizing - especially since our patch to support
> -moz-stack-sizing is in mozilla-central, and so it is only people using
> older versions of Mozilla which don't have this patch who will see the
> warning. It therefore seems like this change will introduce a regression
> for properly patched Mozilla versions.

For information, I don't indeed get those warnings in PCEnv 0.5 under
Windows. I do, however, get them using OpenCell Trunk under Ubuntu 8.10
(i.e. using the XUL Runner SDK) and, I guess, so will people under Mac OS X.

With regards to -moz-stack-sizing itself,
https://developer.mozilla.org/en/CSS/-moz-stack-sizing mentions that "this
article covers features introduced in Firefox 3.1". This was the original
reason I thought it was 'safe' to remove -moz-stack-sizing, but that was
before I was told of this particular patch.

Anyway, I have reverted my changes, even though I really hate those warnings
(it doesn't look professional).

Alan





Archive powered by MHonArc 2.6.18.

Top of page