A list for the developers of CellML tools

Text archives Help


[cellml-dev] r2929 - CellML_DOM_API/trunk/tests


Chronological Thread 
  • From: alan.garny at dpag.ox.ac.uk (Alan Garny)
  • Subject: [cellml-dev] r2929 - CellML_DOM_API/trunk/tests
  • Date: Wed, 26 Nov 2008 13:57:21 -0000

Does it really make sense to have those test files under
http://www.cellml.org/Members/miller/andres_models/? I mean, wouldn't it
make more sense to have those test files in a place that is not 'linked to'
a physical person? If you, Andrew, were to leave the institute, someone
would have to modify things once again, which is somewhat silly.

Alan

> -----Original Message-----
> From: automated-notifications-bounces at cellml.org [mailto:automated-
> notifications-bounces at cellml.org] On Behalf Of CellML Automated
> Notifications
> Sent: 26 November 2008 03:01
> To: automated-notifications at cellml.org
> Subject: r2929 - CellML_DOM_API/trunk/tests
>
> Author: amil082
> Date: 2008-11-26 16:01:26 +1300 (Wed, 26 Nov 2008)
> New Revision: 2929
>
> Modified:
> CellML_DOM_API/trunk/tests/CUSESTest.cpp
> CellML_DOM_API/trunk/tests/CeVASTest.cpp
> CellML_DOM_API/trunk/tests/CellMLTest.cpp
> Log:
> Update tests to work with Andre's tests, which I have now modified to
> make all the paths relative, and moved to
> http://www.cellml.org/Members/miller/andres_models/ , because the IT
> group decided to take down
> http://www.bioeng.auckland.ac.nz/people/nickerso/, which broke our
> tests.
>
> Modified: CellML_DOM_API/trunk/tests/CUSESTest.cpp
> ===================================================================
> --- CellML_DOM_API/trunk/tests/CUSESTest.cpp 2008-11-25 23:19:59 UTC
> (rev 2928)
> +++ CellML_DOM_API/trunk/tests/CUSESTest.cpp 2008-11-26 03:01:26 UTC
> (rev 2929)
> @@ -44,7 +44,7 @@
> {
> iface::cellml_api::Model* tenTusscher =
> mModelLoader->loadFromURL
> -
> (L"http://www.bioeng.auckland.ac.nz/people/nickerso/research/models/";
> + (L"http://www.cellml.org/Members/miller/andres_models/";
> L"2004_tenTusscher/experiments/periodic-stimulus-
> endocardial.xml");
> iface::cellml_services::CUSES* c =
> mCUSESBootstrap->createCUSESForModel(tenTusscher, false);
>
> Modified: CellML_DOM_API/trunk/tests/CeVASTest.cpp
> ===================================================================
> --- CellML_DOM_API/trunk/tests/CeVASTest.cpp 2008-11-25 23:19:59 UTC
> (rev 2928)
> +++ CellML_DOM_API/trunk/tests/CeVASTest.cpp 2008-11-26 03:01:26 UTC
> (rev 2929)
> @@ -44,7 +44,7 @@
> CeVASTest::testCeVASCore()
> {
> iface::cellml_api::Model* tenTusscher = mModelLoader->loadFromURL
> -
> (L"http://www.bioeng.auckland.ac.nz/people/nickerso/research/models/";
> + (L"http://www.cellml.org/Members/miller/andres_models/";
> L"2004_tenTusscher/experiments/periodic-stimulus-
> endocardial.xml");
>
> // interface CeVASBootstrap
>
> Modified: CellML_DOM_API/trunk/tests/CellMLTest.cpp
> ===================================================================
> --- CellML_DOM_API/trunk/tests/CellMLTest.cpp 2008-11-25 23:19:59 UTC
> (rev 2928)
> +++ CellML_DOM_API/trunk/tests/CellMLTest.cpp 2008-11-26 03:01:26 UTC
> (rev 2929)
> @@ -67,7 +67,7 @@
> {
> mTenTusscher =
> mModelLoader->loadFromURL
> -
> (L"http://www.bioeng.auckland.ac.nz/people/nickerso/research/models/";
> + (L"http://www.cellml.org/Members/miller/andres_models/";
> L"2004_tenTusscher/experiments/periodic-stimulus-
> endocardial.xml");
> }
>
> @@ -1233,16 +1233,14 @@
> iface::cellml_api::URI* xh;
> CPPUNIT_ASSERT_NO_THROW(xh = ci->xlinkHref());
> CPPUNIT_ASSERT_NO_THROW(str = xh->asText());
> - CPPUNIT_ASSERT(!wcscmp(str,
> L"http://www.bioeng.auckland.ac.nz/people/";
> -
> L"nickerso/research/models/common/units.xml"));
> + CPPUNIT_ASSERT(!wcscmp(str, L"../../common/units.xml"));
> free(str);
> xh->release_ref();
> ci->release_ref();
> CPPUNIT_ASSERT_NO_THROW(ci = cii->nextImport());
> CPPUNIT_ASSERT_NO_THROW(xh = ci->xlinkHref());
> CPPUNIT_ASSERT_NO_THROW(str = xh->asText());
> - CPPUNIT_ASSERT(!wcscmp(str,
> L"http://www.bioeng.auckland.ac.nz/people/";
> -
> L"nickerso/research/models/2004_tenTusscher/2004_"
> + CPPUNIT_ASSERT(!wcscmp(str, L"../2004_"
> L"tenTusscher_noble_noble_panfilov-
> endo.xml"));
> free(str);
> xh->release_ref();
> @@ -2114,15 +2112,14 @@
> // readonly attribute URI xlinkHref;
> iface::cellml_api::URI* u = ci1->xlinkHref();
> wchar_t* str = u->asText();
> - CPPUNIT_ASSERT(!wcscmp(str,
> L"http://www.bioeng.auckland.ac.nz/people/";
> -
> L"nickerso/research/models/common/units.xml"));
> + CPPUNIT_ASSERT(!wcscmp(str, L"../../common/units.xml"));
> free(str);
> u->asText(L"http://www.example.org/models/test.xml";);
> str = u->asText();
> CPPUNIT_ASSERT(!wcscmp(str,
> L"http://www.example.org/models/test.xml";));
> free(str);
> - u-
> >asText(L"http://www.bioeng.auckland.ac.nz/people/nickerso/research/";
> - L"models/common/units.xml");
> + u->asText(L"http://www.cellml.org/Members/miller/andres_models/";
> + L"common/units.xml");
> u->release_ref();
>
> // /**
>
> _______________________________________________
> automated-notifications mailing list
> automated-notifications at cellml.org
> http://www.cellml.org/mailman/listinfo/automated-notifications





Archive powered by MHonArc 2.6.18.

Top of page