A list for the developers of CellML tools

Text archives Help


[cellml-dev] r2919 - pce/trunk/chrome/content/ui


Chronological Thread 
  • From: ak.miller at auckland.ac.nz (Andrew Miller)
  • Subject: [cellml-dev] r2919 - pce/trunk/chrome/content/ui
  • Date: Thu, 20 Nov 2008 10:05:34 +1300

Alan Garny wrote:
> I don't agree with this fix. The .cml extension is an extension that I
> introduced in COR for CellML files several years ago and which I was told
> wasn't 'good', etc. and which was, as a result, dropped in favour of the
> .cellml extension. So, I would expect the .cml extension to be dropped
> altogether. If anything, the .xml extension (in addition to the .cellml
> extension) could be used, though I would personally vote against it.
>
Hi Alan,

The purpose of this change is to ensure .cml is not used as the default
for saving - the *.cml was already in the filter list, I just moved it
to the end. There are still CellML files with the .cml extension, so the
correct behaviour is to allow users to open them, but not encourage
users to save using that extension.

Best wishes,
Andrew

> Alan
>
>
>> -----Original Message-----
>> From: automated-notifications-bounces at cellml.org [mailto:automated-
>> notifications-bounces at cellml.org] On Behalf Of CellML Automated
>> Notifications
>> Sent: 19 November 2008 01:26
>> To: automated-notifications at cellml.org
>> Subject: r2919 - pce/trunk/chrome/content/ui
>>
>> Author: amil082
>> Date: 2008-11-19 14:26:11 +1300 (Wed, 19 Nov 2008)
>> New Revision: 2919
>>
>> Modified:
>> pce/trunk/chrome/content/ui/Menu.js
>> Log:
>> Change the order of the file filters to make the deprecated and
>> discouraged *.cml option last. See tracker item 1502, which should be
>> fixed by this.
>>
>> Modified: pce/trunk/chrome/content/ui/Menu.js
>> ===================================================================
>> --- pce/trunk/chrome/content/ui/Menu.js 2008-11-19 00:56:34 UTC (rev
>> 2918)
>> +++ pce/trunk/chrome/content/ui/Menu.js 2008-11-19 01:26:11 UTC (rev
>> 2919)
>> @@ -44,7 +44,7 @@
>> var fp = Components.classes["@mozilla.org/filepicker;1"]
>> .createInstance(nsIFilePicker);
>> fp.init(window, "Select a model file", nsIFilePicker.modeOpenMultiple);
>> - fp.appendFilter("CellML Models","*.cml; *.cellml; *.xml");
>> + fp.appendFilter("CellML Models","*.cellml; *.xml; *.cml");
>> fp.appendFilter("XML Files","*.xml");
>> fp.appendFilter("All Files","*");
>> if (fp.show() != nsIFilePicker.returnOK)
>> @@ -113,7 +113,7 @@
>> .createInstance(nsIFilePicker);
>> fp.init(window, "Select a model file", nsIFilePicker.modeSave);
>> fp.defaultExtension = "cellml";
>> - fp.appendFilter("CellML Models","*.cml; *.cellml; *.xml");
>> + fp.appendFilter("CellML Models","*.cellml; *.xml; *.cml");
>> fp.appendFilter("XML Files","*.xml");
>> fp.appendFilter("All Files","*");
>> if (fp.show() == nsIFilePicker.returnCancel)
>>
>> _______________________________________________
>> automated-notifications mailing list
>> automated-notifications at cellml.org
>> http://www.cellml.org/mailman/listinfo/automated-notifications
>>
>
> _______________________________________________
> cellml-tools-developers mailing list
> cellml-tools-developers at cellml.org
> http://www.cellml.org/mailman/listinfo/cellml-tools-developers
>





Archive powered by MHonArc 2.6.18.

Top of page